netdev - Re: [PATCH bpf 1/2] xdp, bonding: Fix feature flags when there are no slave devs anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: 
 <170968502778.5704.4519517843918140180.git-patchwork-notify@kernel.org>
Date: Wed, 06 Mar 2024 00:30:27 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Daniel Borkmann <daniel@...earbox.net>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, magnus.karlsson@...el.com,
 prbatra.mail@...il.com, toke@...hat.com, kuba@...nel.org
Subject: Re: [PATCH bpf 1/2] xdp,
 bonding: Fix feature flags when there are no slave devs anymore

Hello:

This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Tue,  5 Mar 2024 10:08:28 +0100 you wrote:
> Commit 9b0ed890ac2a ("bonding: do not report NETDEV_XDP_ACT_XSK_ZEROCOPY")
> changed the driver from reporting everything as supported before a device
> was bonded into having the driver report that no XDP feature is supported
> until a real device is bonded as it seems to be more truthful given
> eventually real underlying devices decide what XDP features are supported.
> 
> The change however did not take into account when all slave devices get
> removed from the bond device. In this case after 9b0ed890ac2a, the driver
> keeps reporting a feature mask of 0x77, that is, NETDEV_XDP_ACT_MASK &
> ~NETDEV_XDP_ACT_XSK_ZEROCOPY whereas it should have reported a feature
> mask of 0.
> 
> [...]

Here is the summary with links:
  - [bpf,1/2] xdp, bonding: Fix feature flags when there are no slave devs anymore
    https://git.kernel.org/bpf/bpf/c/f267f2628150
  - [bpf,2/2] selftests/bpf: Fix up xdp bonding test wrt feature flags
    https://git.kernel.org/bpf/bpf/c/0bfc0336e134

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html