netdev - Re: [PATCH bpf] cpumap: Zero-initialise xdp_rxq_info struct before running XDP program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 06 Mar 2024 01:10:25 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Toke Høiland-Jørgensen <toke@...hat.com>@codeaurora.org
Cc: ast@...nel.org, daniel@...earbox.net, davem@...emloft.net,
 kuba@...nel.org, hawk@...nel.org, john.fastabend@...il.com,
 andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org,
 yonghong.song@...ux.dev, kpsingh@...nel.org, sdf@...gle.com,
 haoluo@...gle.com, jolsa@...nel.org, lorenzo@...nel.org, tobias@...or.de,
 netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf] cpumap: Zero-initialise xdp_rxq_info struct before
 running XDP program

Hello:

This patch was applied to bpf/bpf.git (master)
by Martin KaFai Lau <martin.lau@...nel.org>:

On Tue,  5 Mar 2024 22:31:32 +0100 you wrote:
> When running an XDP program that is attached to a cpumap entry, we don't
> initialise the xdp_rxq_info data structure being used in the xdp_buff
> that backs the XDP program invocation. Tobias noticed that this leads to
> random values being returned as the xdp_md->rx_queue_index value for XDP
> programs running in a cpumap.
> 
> This means we're basically returning the contents of the uninitialised
> memory, which is bad. Fix this by zero-initialising the rxq data
> structure before running the XDP program.
> 
> [...]

Here is the summary with links:
  - [bpf] cpumap: Zero-initialise xdp_rxq_info struct before running XDP program
    https://git.kernel.org/bpf/bpf/c/2487007aa3b9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html