netdev - Re: [PATCH ipsec-next v1 8/8] iptfs: impl: add new iptfs xfrm mode impl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BB1F8623-7FBE-4FD4-A561-40DAD91F70E1@chopps.org>
Date: Wed, 6 Mar 2024 10:30:32 -0500
From: Christian Hopps <chopps@...pps.org>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: Christian Hopps <chopps@...pps.org>,
 Steffen Klassert <steffen.klassert@...unet.com>,
 netdev@...r.kernel.org,
 devel@...ux-ipsec.org
Subject: Re: [PATCH ipsec-next v1 8/8] iptfs: impl: add new iptfs xfrm mode
 impl

I'll go through the other comments this week; however...

> On Mar 6, 2024, at 08:57, Sabrina Dubroca <sd@...asysnail.net> wrote:
> 
>> +/* ------------------------------- */
>> +/* Input (Egress) Re-ordering Code */
>> +/* ------------------------------- */
> 
> nit: ingress? The whole patch seems to mix up ingress/egress and
> send/receive.

No, they are in fact correct in the whole patch. :)

"Tunnel ingress" is handled by xfrm output functions and "Tunnel Egress" are handled by xfrm input or receive functions.

The input routines take packets from inside the tunnel and move them out of the tunnel i.e., they are exiting (egressing) the tunnel.

If you replace "Ingress" and "Egress" with their English equivalents "Enter" and "Exit" maybe it's more obvious... As a routing and briefly an operations guy though I'll say that ingress and egress are used almost exclusively for tunnels rather than "enter" and "exit". :)

Thanks,
Chris.