netdev - Re: [PATCH net-next v2 00/22] Introducing OpenVPN Data Channel Offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31c1d654-c5b4-45a1-a8e3-48e631f915ab@openvpn.net>
Date: Wed, 6 Mar 2024 16:44:41 +0100
From: Antonio Quartulli <antonio@...nvpn.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Sergey Ryazanov <ryazanov.s.a@...il.com>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v2 00/22] Introducing OpenVPN Data Channel
 Offload

On 05/03/2024 20:30, Jakub Kicinski wrote:
> On Mon,  4 Mar 2024 16:08:51 +0100 Antonio Quartulli wrote:
>>   create mode 100644 drivers/net/ovpn/Makefile
>>   create mode 100644 drivers/net/ovpn/bind.c
>>   create mode 100644 drivers/net/ovpn/bind.h
>>   create mode 100644 drivers/net/ovpn/crypto.c
>>   create mode 100644 drivers/net/ovpn/crypto.h
>>   create mode 100644 drivers/net/ovpn/crypto_aead.c
>>   create mode 100644 drivers/net/ovpn/crypto_aead.h
>>   create mode 100644 drivers/net/ovpn/io.c
>>   create mode 100644 drivers/net/ovpn/io.h
>>   create mode 100644 drivers/net/ovpn/main.c
>>   create mode 100644 drivers/net/ovpn/main.h
>>   create mode 100644 drivers/net/ovpn/netlink.c
>>   create mode 100644 drivers/net/ovpn/netlink.h
>>   create mode 100644 drivers/net/ovpn/ovpnstruct.h
>>   create mode 100644 drivers/net/ovpn/packet.h
>>   create mode 100644 drivers/net/ovpn/peer.c
>>   create mode 100644 drivers/net/ovpn/peer.h
>>   create mode 100644 drivers/net/ovpn/pktid.c
>>   create mode 100644 drivers/net/ovpn/pktid.h
>>   create mode 100644 drivers/net/ovpn/proto.h
>>   create mode 100644 drivers/net/ovpn/skb.h
>>   create mode 100644 drivers/net/ovpn/socket.c
>>   create mode 100644 drivers/net/ovpn/socket.h
>>   create mode 100644 drivers/net/ovpn/stats.c
>>   create mode 100644 drivers/net/ovpn/stats.h
>>   create mode 100644 drivers/net/ovpn/tcp.c
>>   create mode 100644 drivers/net/ovpn/tcp.h
>>   create mode 100644 drivers/net/ovpn/udp.c
>>   create mode 100644 drivers/net/ovpn/udp.h
>>   create mode 100644 include/uapi/linux/ovpn.h
> 
> At a glance you seem to be missing:
>   - documentation
>   - YAML spec for the netlink protocol -
>     https://docs.kernel.org/next/userspace-api/netlink/specs.html

triple ACK on the doc :) will add more.

>   - some basic set of tests (or mention that you'll run your own CI
>     and report results to us: https://netdev.bots.linux.dev/status.html)

I currently have a small userspace tool (that implements the netlink 
APIs) and a script that by means of netns and this tool runs a bunch of 
tests.

Is there any requirement about how the test should work so that I can 
make it compatible with your harness? I will then push it to 
/tools/testing/selftests/ovpn so that you can pick it up.

Thanks a lot!

Regards,

> :)

-- 
Antonio Quartulli
OpenVPN Inc.