netdev - Re: [PATCH net-next v6 11/16] net: dsa: tag_sja1105: refactor skb->dev assignment to dsa_tag_8021q_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9a0117e-3a0b-485b-b92d-81ab18e7d2cb@gmail.com>
Date: Wed, 6 Mar 2024 15:12:45 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Pawel Dembicki <paweldembicki@...il.com>, netdev@...r.kernel.org
Cc: Linus Walleij <linus.walleij@...aro.org>, Simon Horman
 <horms@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>,
 Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Claudiu Manoil <claudiu.manoil@....com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 UNGLinuxDriver@...rochip.com, Russell King <linux@...linux.org.uk>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 11/16] net: dsa: tag_sja1105: refactor
 skb->dev assignment to dsa_tag_8021q_find_user()

On 3/1/24 14:16, Pawel Dembicki wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> A new tagging protocol implementation based on tag_8021q is on the
> horizon, and it appears that it also has to open-code the complicated
> logic of finding a source port based on a VLAN header.
> 
> Create a single dsa_tag_8021q_find_user() and make sja1105 call it.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian