netdev - Re: [PATCH] ice: Fix enabling SR-IOV with Xen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <713a5e32-d998-4510-a82f-cc3dc51c725c@intel.com>
Date: Wed, 6 Mar 2024 15:44:11 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: <javi.merino@...nel.org>, <netdev@...r.kernel.org>
CC: <intel-wired-lan@...ts.osuosl.org>, Ross Lagerwall
	<ross.lagerwall@...rix.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH] ice: Fix enabling SR-IOV with Xen

On 3/1/2024 10:28 AM, javi.merino@...nel.org wrote:
> From: Ross Lagerwall <ross.lagerwall@...rix.com>
>
> I'm unsure about the error path if `pci_enable_sriov()` fails.  Do we
> have to undo what `ice_start_vfs()` has started?  I can see that
> `ice_start_vfs()` has a teardown at the end, so maybe we need the same
> code if `pci_enable_sriov()` fails?

Yes, we should teardown the ice_start_vfs() work if pci_enable_sriov() 
fails.

Thanks,
Tony