netdev - Re: [PATCH net-next 00/18] net: group together hot data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cfe2f75-d492-4e22-b167-3eab5f3cdcdb@kernel.org>
Date: Tue, 5 Mar 2024 21:39:11 -0700
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>,
 Soheil Hassas Yeganeh <soheil@...gle.com>,
 Neal Cardwell <ncardwell@...gle.com>, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 00/18] net: group together hot data

On 3/5/24 9:03 AM, Eric Dumazet wrote:
> While our recent structure reorganizations were focused
> on increasing max throughput, there is still an
> area where improvements are much needed.
> 
> In many cases, a cpu handles one packet at a time,
> instead of a nice batch.
> 
> Hardware interrupt.
>  -> Software interrupt.
>    -> Network/Protocol stacks.
> 
> If the cpu was idle or busy in other layers,
> it has to pull many cache lines.
> 
> This series adds a new net_hotdata structure, where
> some critical (and read-mostly) data used in
> rx and tx path is packed in a small number of cache lines.
> 
> Synthetic benchmarks will not see much difference,
> but latency of single packet should improve.
> 
> net_hodata current size on 64bit is 416 bytes,
> but might grow in the future.
> 
> Also move RPS definitions to a new include file.
> 

Interesting patch set. For the set:

Reviewed-by: David Ahern <dsahern@...nel.org>