netdev - Re: [PATCH net v4] ipv6: fib6_rules: flush route cache when rule is changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b642c63273f0dd25dbde3a48aa61903f74ac6b92.camel@mediatek.com>
Date: Wed, 6 Mar 2024 07:28:39 +0000
From: Lena Wang (王娜) <Lena.Wang@...iatek.com>
To: "horms@...nel.org" <horms@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dsahern@...nel.org" <dsahern@...nel.org>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "kuba@...nel.org" <kuba@...nel.org>,
	Shiming Cheng (成诗明)
	<Shiming.Cheng@...iatek.com>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net v4] ipv6: fib6_rules: flush route cache when rule is
 changed

On Tue, 2024-03-05 at 15:23 +0000, Simon Horman wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Tue, Mar 05, 2024 at 01:01:24PM +0000, Lena Wang (王娜) wrote:
> > On Mon, 2024-03-04 at 20:45 -0800, Jakub Kicinski wrote:
> > >   
> > > External email : Please do not click links or open attachments
> until
> > > you have verified the sender or the content.
> > >  On Fri, 1 Mar 2024 14:39:46 +0000 Lena Wang (王娜) wrote:
> > > > From: Shiming Cheng <shiming.cheng@...iatek.com>
> > > > 
> > > > When rule policy is changed, ipv6 socket cache is not
> refreshed.
> > > > The sock's skb still uses a outdated route cache and was sent
> to
> > > > a wrong interface.
> > > > 
> > > > To avoid this error we should update fib node's version when
> > > > rule is changed. Then skb's route will be reroute checked as
> > > > route cache version is already different with fib node version.
> > > > The route cache is refreshed to match the latest rule.
> > > 
> > > Doesn't apply, please rebase on top of latest net/main.
> > Hi Jakub,
> > I use master branch to make this patch. And it seems same with
> > main branch of kernel/git/netdev/net.git.
> > 
> > Could you tell me which branch should be used?
> > 
> > Thanks
> > Lena
> 
> Hi Lena,
> 
> The primary branch is main these days.
> If you are using master than it may well be stale.
> 
> For reference, the current HEAD commit is.
> 
> 4daa873133d3 ("Merge tag 'mlx5-fixes-2024-03-01' of
> git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux")

Hi Simon,
I clone a latest netdev main branch (on the 4daa873133d3) and make a
new patch diff. However it is totally same with PATCH v4.

Could you please help to check where the stale code is? 


Thanks
Lena