netdev - Re: [PATCH net-next v3 10/12] net: ethernet: oa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9abd5656-3bfe-41ba-9f56-03f6e905a4b8@microchip.com>
Date: Thu, 7 Mar 2024 10:16:14 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <Woojung.Huh@...rochip.com>
CC: <UNGLinuxDriver@...rochip.com>, <Thorsten.Kummermehr@...rochip.com>,
	<Pier.Beruto@...emi.com>, <Selvamani.Rajagopal@...emi.com>,
	<Nicolas.Ferre@...rochip.com>, <benjamin.bigler@...nformulastudent.ch>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <horms@...nel.org>, <saeedm@...dia.com>,
	<anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <andrew@...n.ch>, <corbet@....net>,
	<linux-doc@...r.kernel.org>, <robh+dt@...nel.org>,
	<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <Horatiu.Vultur@...rochip.com>,
	<ruanjinjie@...wei.com>, <Steen.Hegelund@...rochip.com>,
	<vladimir.oltean@....com>
Subject: Re: [PATCH net-next v3 10/12] net: ethernet: oa_tc6: implement
 mac-phy interrupt

Hi Woojung,

On 07/03/24 5:12 am, Woojung Huh - C21699 wrote:
> Hi Parthiban,
> 
> ...
> 
>> +static irqreturn_t oa_tc6_macphy_isr(int irq, void *data)
>> +{
>> +	struct oa_tc6 *tc6 = data;
>> +
>> +	/* MAC-PHY interrupt can occur for the following reasons.
>> +	 * - availability of tx credits if it was 0 before and not reported
>> in
>> +	 *   the previous rx footer.
> 
> Per description above, it may be typo of "the previous rx footer"
Sorry, I don't get your comment. Could you please elaborate?

Best regards,
Parthiban V
> 
>> +	 * - availability of rx chunks if it was 0 before and not reported
>> in
>> +	 *   the previous rx footer.
>> +	 * - extended status event not reported in the previous rx footer.
>> +	 */
>> +	tc6->int_flag = true;
>> +	/* Wake spi kthread to perform spi transfer */
>> +	wake_up_interruptible(&tc6->spi_wq);
>> +
>> +	return IRQ_HANDLED;
>> +}
>> +
>