netdev - Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bk7qnrxt.fsf@mail.lhotse>
Date: Thu, 07 Mar 2024 23:32:14 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Dawei Li <set_pte_at@...look.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>
Cc: "npiggin@...il.com" <npiggin@...il.com>, "linuxppc-dev@...ts.ozlabs.org"
 <linuxppc-dev@...ts.ozlabs.org>, "linux-ide@...r.kernel.org"
 <linux-ide@...r.kernel.org>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-wireless@...r.kernel.org"
 <linux-wireless@...r.kernel.org>, "linux-scsi@...r.kernel.org"
 <linux-scsi@...r.kernel.org>, "linux-serial@...r.kernel.org"
 <linux-serial@...r.kernel.org>, "alsa-devel@...a-project.org"
 <alsa-devel@...a-project.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver
 void returned

Dawei Li <set_pte_at@...look.com> writes:
> Hi Christophe,
>
> On Tue, Feb 20, 2024 at 04:12:17PM +0000, Christophe Leroy wrote:
>> Hi Michael,
>> 
>> ping ?
>> 
>> Le 01/02/2023 à 15:36, Dawei Li a écrit :
>> > Commit fc7a6209d571 ("bus: Make remove callback return void") forces
>> > bus_type::remove be void-returned, it doesn't make much sense for any
>> > bus based driver implementing remove callbalk to return non-void to
>> > its caller.
>> > 
>> > This change is for macio bus based drivers.
>> > 
>> > Signed-off-by: Dawei Li <set_pte_at@...look.com>
>> 
>> This patch is Acked , any special reason for not applying it ?
>> 
>> Note that it now conflicts with commit 1535d5962d79 ("wifi: remove 
>> orphaned orinoco driver") but resolution is trivial, just drop the 
>> changes to that file.
>
> Thanks for picking it up, hardly believe that it's been one year.
>
> Michael,
>
> I will respin V4 if it's needed.

No that's fine, I'll sort it out.

cheers