netdev - Re: [xdp-hints] Re: [Intel-wired-lan] [PATCH iwl-next, v3 2/2] igc: Add Tx hardware timestamp request for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5nago13.fsf@kurt.kurt.home>
Date: Thu, 07 Mar 2024 14:38:32 +0100
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>, Song Yoong Siang
 <yoong.siang.song@...el.com>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Richard Cochran
 <richardcochran@...il.com>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, Stanislav Fomichev
 <sdf@...gle.com>, Vinicius Costa Gomes <vinicius.gomes@...el.com>, Florian
 Bezdeka <florian.bezdeka@...mens.com>, Andrii Nakryiko
 <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>, Mykola Lysenko
 <mykolal@...com>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu
 <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, KP Singh
 <kpsingh@...nel.org>, Hao Luo <haoluo@...gle.com>, Jiri Olsa
 <jolsa@...nel.org>, Shuah Khan <shuah@...nel.org>,
 xdp-hints@...-project.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
 linux-kselftest@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [xdp-hints] Re: [Intel-wired-lan] [PATCH iwl-next, v3 2/2] igc:
 Add Tx hardware timestamp request for AF_XDP zero-copy packet

Hi Maciej,

On Wed Mar 06 2024, Maciej Fijalkowski wrote:
> On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote:
>> -	tstamp->skb = NULL;
>> +	/* Copy the tx hardware timestamp into xdp metadata or skb */
>> +	if (tstamp->buffer_type == IGC_TX_BUFFER_TYPE_XSK)
>
> I believe this should also be protected with xp_tx_metadata_enabled()
> check. We recently had following bugfix, PTAL:
>
> https://lore.kernel.org/bpf/20240222-stmmac_xdp-v2-1-4beee3a037e4@linutronix.de/
>
> I'll take a deeper look at patch tomorrow, might be the case that you've
> addressed that or you were aware of this issue but anyways wanted to bring
> it up. Just check that you don't break standard XDP/AF_XDP traffic :)

This one doesn't crash standard AF_XDP traffic. Don't know why, but it
seems to work.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)