netdev - Re: [PATCH net-next] nexthop: Simplify dump error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52eea550-1179-42f4-a09d-083b2bda22a6@kernel.org>
Date: Thu, 7 Mar 2024 12:28:32 -0700
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, petrm@...dia.com
Subject: Re: [PATCH net-next] nexthop: Simplify dump error handling

On 3/7/24 8:47 AM, Ido Schimmel wrote:
> The only error that can happen during a nexthop dump is insufficient
> space in the skb caring the netlink messages (EMSGSIZE). If this happens
> and some messages were already filled in, the nexthop code returns the
> skb length to signal the netlink core that more objects need to be
> dumped.
> 
> After commit b5a899154aa9 ("netlink: handle EMSGSIZE errors in the
> core") there is no need to handle this error in the nexthop code as it
> is now handled in the core.
> 
> Simplify the code and simply return the error to the core.
> 
> No regressions in nexthop tests:
> 
>  # ./fib_nexthops.sh
>  Tests passed: 234
>  Tests failed:   0
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/ipv4/nexthop.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>