[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5592aeca-608f-4817-8848-99deb2815ddc@broadcom.com>
Date: Thu, 7 Mar 2024 12:21:26 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Daniil Dulov <d.dulov@...ddin.ru>, Doug Berger <opendmb@...il.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>, Russell King
<linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] net: phy: mdio-bcm-unimac: Cast denominator to unsigned
long to avoid overflow
On 3/7/2024 5:19 AM, Daniil Dulov wrote:
> The expression priv->clk_freq * 2 can lead to overflow that will cause
> a division by zero. So, let's cast it to unsigned long to avoid it.
It will not in real life because the maximum clock frequency is 250MHz,
but it also does not hurt.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: b78ac6ecd1b6 ("net: phy: mdio-bcm-unimac: Allow configuring MDIO clock divider")
> Signed-off-by: Daniil Dulov <d.dulov@...ddin.ru>
Acked-by: Florian Fainelli <florian.fainelli@...adcom.com>
--
Florian
Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)
Powered by blists - more mailing lists