netdev - Re: [PATCH net-next v3 0/3] netdev: add per-queue statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1709783855.0510879-1-xuanzhuo@linux.alibaba.com>
Date: Thu, 7 Mar 2024 11:57:35 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 edumazet@...gle.com,
 pabeni@...hat.com,
 amritha.nambiar@...el.com,
 danielj@...dia.com,
 mst@...hat.com,
 michael.chan@...adcom.com,
 sdf@...gle.com,
 przemyslaw.kitszel@...el.com,
 Jakub Kicinski <kuba@...nel.org>,
 davem@...emloft.net
Subject: Re: [PATCH net-next v3 0/3] netdev: add per-queue statistics


For series:

Reviewed-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>

On Wed,  6 Mar 2024 11:55:06 -0800, Jakub Kicinski <kuba@...nel.org> wrote:
> Hi!
>
> Per queue stats keep coming up, so it's about time someone laid
> the foundation. This series adds the uAPI, a handful of stats
> and a sample support for bnxt. It's not very comprehensive in
> terms of stat types or driver support. The expectation is that
> the support will grow organically. If we have the basic pieces
> in place it will be easy for reviewers to request new stats,
> or use of the API in place of ethtool -S.
>
> See patch 3 for sample output.
>
> v3:
>  - remove the dump error handling, core does it now (b5a899154aa94)
>  - fix ring mapping w/ XDP in bnxt
> v2: https://lore.kernel.org/all/20240229010221.2408413-1-kuba@kernel.org/
>  - un-wrap short lines
>  - s/stats/qstats/
> v1: https://lore.kernel.org/all/20240226211015.1244807-1-kuba@kernel.org/
>  - rename projection -> scope
>  - turn projection/scope into flags
>  - remove the "netdev" scope since it's always implied
> rfc: https://lore.kernel.org/all/20240222223629.158254-1-kuba@kernel.org/
>
> Jakub Kicinski (3):
>   netdev: add per-queue statistics
>   netdev: add queue stat for alloc failures
>   eth: bnxt: support per-queue statistics
>
>  Documentation/netlink/specs/netdev.yaml   |  91 +++++++++
>  Documentation/networking/statistics.rst   |  15 ++
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c |  65 +++++++
>  include/linux/netdevice.h                 |   3 +
>  include/net/netdev_queues.h               |  56 ++++++
>  include/uapi/linux/netdev.h               |  20 ++
>  net/core/netdev-genl-gen.c                |  12 ++
>  net/core/netdev-genl-gen.h                |   2 +
>  net/core/netdev-genl.c                    | 214 ++++++++++++++++++++++
>  tools/include/uapi/linux/netdev.h         |  20 ++
>  10 files changed, 498 insertions(+)
>
> --
> 2.44.0
>
>