netdev - Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240306202724.670fb304@kernel.org>
Date: Wed, 6 Mar 2024 20:27:24 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
 edumazet@...gle.com, arkadiusz.kubalewski@...el.com,
 vadim.fedorenko@...ux.dev
Subject: Re: [patch net-next] dpll: spec: use proper enum for pin
 capabilities attribute

On Wed,  6 Mar 2024 13:07:39 +0100 Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> The enum is defined, however the pin capabilities attribute does
> refer to it. Add this missing enum field.
> 
> This fixes ynl cli output:
> 
> Example current output:
> $ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
> {'capabilities': 4,
>  ...
> Example new output:
> $ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
> {'capabilities': {'state-can-change'},
>  ...
> 
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>