netdev - Doesn't compile commit 0d60d8df6f49 ("dpll: rely on rcu for netdev_dpll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <70C97E7F-767B-4E75-A454-E4468505F248@suse.de>
Date: Thu, 7 Mar 2024 14:14:11 +0800
From: Coly Li <colyli@...e.de>
To: edumazet@...gle.com
Cc: arkadiusz.kubalewski@...el.com,
 vadim.fedorenko@...ux.dev,
 netdev@...r.kernel.org
Subject: Doesn't compile commit 0d60d8df6f49 ("dpll: rely on rcu for
 netdev_dpll_pin()")

Hi folks,

The commit 0d60d8df6f49 ("dpll: rely on rcu for netdev_dpll_pin()”) doesn’t compile and see the following error message,

colyli@x:~/source/linux/linux> make
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  DESCEND bpf/resolve_btfids
  INSTALL libsubcmd_headers
  CC      net/core/dev.o
In file included from ./arch/x86/include/generated/asm/rwonce.h:1:0,
                 from ./include/linux/compiler.h:251,
                 from ./include/linux/instrumented.h:10,
                 from ./include/linux/uaccess.h:6,
                 from net/core/dev.c:71:
net/core/dev.c: In function ‘netdev_dpll_pin_assign’:
./include/linux/rcupdate.h:462:36: error: dereferencing pointer to incomplete type ‘struct dpll_pin’
 #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v)
                                    ^~~~
./include/asm-generic/rwonce.h:55:33: note: in definition of macro ‘__WRITE_ONCE’
  *(volatile typeof(x) *)&(x) = (val);    \
                                 ^~~
./arch/x86/include/asm/barrier.h:67:2: note: in expansion of macro ‘WRITE_ONCE’
  WRITE_ONCE(*p, v);      \
  ^~~~~~~~~~
./include/asm-generic/barrier.h:172:55: note: in expansion of macro ‘__smp_store_release’
 #define smp_store_release(p, v) do { kcsan_release(); __smp_store_release(p, v); } while (0)
                                                       ^~~~~~~~~~~~~~~~~~~
./include/linux/rcupdate.h:503:3: note: in expansion of macro ‘smp_store_release’
   smp_store_release(&p, RCU_INITIALIZER((typeof(p))_r_a_p__v)); \
   ^~~~~~~~~~~~~~~~~
./include/linux/rcupdate.h:503:25: note: in expansion of macro ‘RCU_INITIALIZER’
   smp_store_release(&p, RCU_INITIALIZER((typeof(p))_r_a_p__v)); \
                         ^~~~~~~~~~~~~~~
net/core/dev.c:9081:2: note: in expansion of macro ‘rcu_assign_pointer’
  rcu_assign_pointer(dev->dpll_pin, dpll_pin);
  ^~~~~~~~~~~~~~~~~~
make[4]: *** [scripts/Makefile.build:243: net/core/dev.o] Error 1
make[3]: *** [scripts/Makefile.build:481: net/core] Error 2
make[2]: *** [scripts/Makefile.build:481: net] Error 2
make[1]: *** [/home/colyli/source/linux/linux/Makefile:1921: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2

Can anyone help to take a look? Thanks.

Coly Li