netdev - Re: Doesn't compile commit 0d60d8df6f49 ("dpll: rely on rcu for netdev_dpll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D26DFFCB-1FF2-40E4-BD0B-F0410471650B@suse.de>
Date: Thu, 7 Mar 2024 14:38:50 +0800
From: Coly Li <colyli@...e.de>
To: Eric Dumazet <edumazet@...gle.com>
Cc: arkadiusz.kubalewski@...el.com,
 vadim.fedorenko@...ux.dev,
 netdev@...r.kernel.org
Subject: Re: Doesn't compile commit 0d60d8df6f49 ("dpll: rely on rcu for
 netdev_dpll_pin()")



> 2024年3月7日 14:35，Eric Dumazet <edumazet@...gle.com> 写道：
> 
> On Thu, Mar 7, 2024 at 7:14 AM Coly Li <colyli@...e.de> wrote:
>> 
>> Hi folks,
>> 
>> The commit 0d60d8df6f49 ("dpll: rely on rcu for netdev_dpll_pin()”) doesn’t compile and see the following error message,
>> 
>> colyli@x:~/source/linux/linux> make
>>  CALL    scripts/checksyscalls.sh
>>  DESCEND objtool
>>  INSTALL libsubcmd_headers
>>  DESCEND bpf/resolve_btfids
>>  INSTALL libsubcmd_headers
>>  CC      net/core/dev.o
>> In file included from ./arch/x86/include/generated/asm/rwonce.h:1:0,
>>                 from ./include/linux/compiler.h:251,
>>                 from ./include/linux/instrumented.h:10,
>>                 from ./include/linux/uaccess.h:6,
>>                 from net/core/dev.c:71:
>> net/core/dev.c: In function ‘netdev_dpll_pin_assign’:
>> ./include/linux/rcupdate.h:462:36: error: dereferencing pointer to incomplete type ‘struct dpll_pin’
>> #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v)
>>                                    ^~~~
>> ./include/asm-generic/rwonce.h:55:33: note: in definition of macro ‘__WRITE_ONCE’
>>  *(volatile typeof(x) *)&(x) = (val);    \
>>                                 ^~~
>> ./arch/x86/include/asm/barrier.h:67:2: note: in expansion of macro ‘WRITE_ONCE’
>>  WRITE_ONCE(*p, v);      \
>>  ^~~~~~~~~~
>> ./include/asm-generic/barrier.h:172:55: note: in expansion of macro ‘__smp_store_release’
>> #define smp_store_release(p, v) do { kcsan_release(); __smp_store_release(p, v); } while (0)
>>                                                       ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/rcupdate.h:503:3: note: in expansion of macro ‘smp_store_release’
>>   smp_store_release(&p, RCU_INITIALIZER((typeof(p))_r_a_p__v)); \
>>   ^~~~~~~~~~~~~~~~~
>> ./include/linux/rcupdate.h:503:25: note: in expansion of macro ‘RCU_INITIALIZER’
>>   smp_store_release(&p, RCU_INITIALIZER((typeof(p))_r_a_p__v)); \
>>                         ^~~~~~~~~~~~~~~
>> net/core/dev.c:9081:2: note: in expansion of macro ‘rcu_assign_pointer’
>>  rcu_assign_pointer(dev->dpll_pin, dpll_pin);
>>  ^~~~~~~~~~~~~~~~~~
>> make[4]: *** [scripts/Makefile.build:243: net/core/dev.o] Error 1
>> make[3]: *** [scripts/Makefile.build:481: net/core] Error 2
>> make[2]: *** [scripts/Makefile.build:481: net] Error 2
>> make[1]: *** [/home/colyli/source/linux/linux/Makefile:1921: .] Error 2
>> make: *** [Makefile:240: __sub-make] Error 2
>> 
>> Can anyone help to take a look? Thanks.
> 
> Look at past messages in netdev@ mailing list, refresh your tree to the latest,
> you will see this is already discussed and fixed.
> 
> 289e922582af5b4721ba02e86bde4d9ba918158a dpll: move all dpll<>netdev
> helpers to dpll code
> 9224fc86f1776193650a33a275cac628952f80a9 ice: fix uninitialized dplls
> mutex usage
> 640f41ed33b5a420e05daf395afae85e6b20c003 dpll: fix build failure due
> to rcu_dereference_check() on unknown type


Indeed, I did that on Linus tree, but last commit of my local log is,

commit 67be068d31d423b857ffd8c34dbcc093f8dfff76 (HEAD -> master, origin/master, origin/HEAD)
Merge: 5274d261404c a50026bdb867
Author: Linus Torvalds <torvalds@...ux-foundation.org>
Date:   Wed Mar 6 08:12:27 2024 -0800

    Merge tag 'vfs-6.8-release.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs


Maybe it is a CDN synchronization delay, I will try to pull again later.

Thanks for the fast response.

Coly Li