netdev - Re: [PATCH v6 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240307082646.6e9198df@bootlin.com>
Date: Thu, 7 Mar 2024 08:26:46 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Yury Norov <yury.norov@...il.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, Andrew Lunn
 <andrew@...n.ch>, Mark Brown <broonie@...nel.org>, Christophe Leroy
 <christophe.leroy@...roup.eu>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v6 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots
 changes support

Hi Yury,

On Wed, 6 Mar 2024 05:06:12 -0800
Yury Norov <yury.norov@...il.com> wrote:

...
> > +static int qmc_hdlc_xlate_ts_info(struct qmc_hdlc *qmc_hdlc,
> > +				  const struct qmc_chan_ts_info *ts_info, u32 *slot_map)
> > +{
> > +	DECLARE_BITMAP(ts_mask_avail, 64);
> > +	DECLARE_BITMAP(ts_mask, 64);
> > +	DECLARE_BITMAP(map, 64);
> > +	u32 array32[2];  
> 
> NIT. Bad name. I'd suggest slot_array, or something.
> 

A new iteration of this series is planned.
I will change to slot_array as suggested.

Best regards,
Hervé