[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <cover.1709901020.git.petrm@nvidia.com>
Date: Fri, 8 Mar 2024 13:59:44 +0100
From: Petr Machata <petrm@...dia.com>
To: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
<pabeni@...hat.com>, <netdev@...r.kernel.org>
CC: Ido Schimmel <idosch@...dia.com>, Petr Machata <petrm@...dia.com>, "David
Ahern" <dsahern@...nel.org>, Shuah Khan <shuah@...nel.org>,
<mlxsw@...dia.com>
Subject: [PATCH net-next 00/11] mlxsw: Support for nexthop group statistics
ECMP is a fundamental component in L3 designs. However, it's fragile. Many
factors influence whether an ECMP group will operate as intended: hash
policy (i.e. the set of fields that contribute to ECMP hash calculation),
neighbor validity, hash seed (which might lead to polarization) or the type
of ECMP group used (hash-threshold or resilient).
At the same time, collection of statistics that would help an operator
determine that the group performs as desired, is difficult.
Support for nexthop group statistics and their HW collection has been
introduced recently. In this patch set, add HW stats collection support
to mlxsw.
This patchset progresses as follows:
- Patches #1 and #2 add nexthop IDs to notifiers.
- Patches #3 and #4 are code-shaping.
- Patches #5, #6 and #7 adjust the flow counter code.
- Patches #8 and #9 add HW nexthop counters.
- Patch #10 adjusts the HW counter code to allow sharing the same counter
for several resilient group buckets with the same NH ID.
- Patch #11 adds a selftest.
Petr Machata (11):
net: nexthop: Initialize NH group ID in resilient NH group notifiers
net: nexthop: Have all NH notifiers carry NH ID
mlxsw: spectrum_router: Rename two functions
mlxsw: spectrum_router: Have mlxsw_sp_nexthop_counter_enable() return
int
mlxsw: spectrum: Allow fetch-and-clear of flow counters
mlxsw: spectrum_router: Avoid allocating NH counters twice
mlxsw: spectrum_router: Add helpers for nexthop counters
mlxsw: spectrum_router: Track NH ID's of group members
mlxsw: spectrum_router: Support nexthop group hardware statistics
mlxsw: spectrum_router: Share nexthop counters in resilient groups
selftests: forwarding: Add a test for NH group stats
.../net/ethernet/mellanox/mlxsw/spectrum.c | 8 +-
.../net/ethernet/mellanox/mlxsw/spectrum.h | 4 +-
.../ethernet/mellanox/mlxsw/spectrum_acl.c | 2 +-
.../ethernet/mellanox/mlxsw/spectrum_dpipe.c | 22 +-
.../mellanox/mlxsw/spectrum_mr_tcam.c | 2 +-
.../ethernet/mellanox/mlxsw/spectrum_router.c | 312 ++++++++++++++++--
.../ethernet/mellanox/mlxsw/spectrum_router.h | 6 +-
include/net/nexthop.h | 2 +-
net/ipv4/nexthop.c | 3 +-
.../testing/selftests/net/forwarding/Makefile | 1 +
tools/testing/selftests/net/forwarding/lib.sh | 34 ++
.../net/forwarding/router_mpath_nh.sh | 13 +
.../net/forwarding/router_mpath_nh_lib.sh | 129 ++++++++
.../net/forwarding/router_mpath_nh_res.sh | 13 +
14 files changed, 505 insertions(+), 46 deletions(-)
create mode 100644 tools/testing/selftests/net/forwarding/router_mpath_nh_lib.sh
--
2.43.0
Powered by blists - more mailing lists