netdev - Re: Ethtool query: Reset advertised speed modes if speed value is not passed in "set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6814906c-3eab-42b6-a44f-36046557f3d0@lunn.ch>
Date: Fri, 8 Mar 2024 16:13:56 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Michal Kubecek <mkubecek@...e.cz>
Cc: "Sagar Dhoot (QUIC)" <quic_sdhoot@...cinc.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Nagarjuna Chaganti (QUIC)" <quic_nchagant@...cinc.com>,
	"Priya Tripathi (QUIC)" <quic_ppriyatr@...cinc.com>
Subject: Re: Ethtool query: Reset advertised speed modes if speed value is
 not passed in "set_link_ksettings"

On Fri, Mar 08, 2024 at 03:16:24PM +0100, Michal Kubecek wrote:
> On Fri, Mar 08, 2024 at 02:56:30PM +0100, Andrew Lunn wrote:
> > On Fri, Mar 08, 2024 at 06:33:00AM +0000, Sagar Dhoot (QUIC) wrote:
> > > Hi Andrew,
> > > 
> > > Thanks for the quick response. Maybe I have put up a confusing scenario.
> > > 
> > > Let me rephrase with autoneg on.
> > > 
> > > 1. "ethtool eth_interface"
> > > 2. "ethtool -s eth_interface speed 25000 autoneg on"
> > 
> > phylib will ignore speed if autoneg is on
> 
> It is not passed there. With "autoneg on", speed, duplex and lanes are
> interpreted as conditions for modes to be advertised, i.e. they are
> translated to the same request as "advertise ..." with list of supported
> modes matching the parameters that were used.

Ah! Interesting. I did not know that.

Thanks
	Andrew