netdev - Re: pull-request: wireless-next-2024-03-08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmqc4qik.fsf@kernel.org>
Date: Fri, 08 Mar 2024 18:50:11 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,  linux-wireless@...r.kernel.org,  Ching-Te Ku
 <ku920601@...ltek.com>,  Ping-Ke Shih <pkshih@...ltek.com>
Subject: Re: pull-request: wireless-next-2024-03-08

Jakub Kicinski <kuba@...nel.org> writes:

> On Fri,  8 Mar 2024 10:04:29 +0000 (UTC) Kalle Valo wrote:
>> here's a pull request to net-next tree, more info below. Please let me know if
>> there are any problems.
>
> coccicheck flags:
>
> drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4: WARNING: possible condition with no effect (if == else)

Thanks, but how did you find this? I'm asking just to understand your process, at
least the pull request shows all green:

https://patchwork.kernel.org/project/netdevbpf/patch/20240308100429.B8EA2C433F1@smtp.kernel.org/

We don't run coccicheck so it's not surprising there are new warnings.

> for a non-urgent follow up. Doesn't look like an obvious false positive.

Ping, could you fix this, please? In the patch please add Closes tag
pointing to Jakub's email and mark it for wireless tree (assuming the
merge window starts on Sunday, otherwise we take it to wireless-next).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches