netdev - Re: [PATCHv2 net-next] tools: ynl-gen: support using pre-defined values in attr checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240308113818.6743abe1@kernel.org>
Date: Fri, 8 Mar 2024 11:38:18 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jiri Pirko
 <jiri@...nulli.us>, Donald Hunter <donald.hunter@...il.com>, Nicolas
 Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCHv2 net-next] tools: ynl-gen: support using pre-defined
 values in attr checks

On Thu,  7 Mar 2024 17:23:57 +0800 Hangbin Liu wrote:
> +        for const in self.family['definitions']:

Looks like this breaks the build, the 'definitions' attribute 
is optional. Try iterating over self.family.consts instead.
It should be initialized by nlspec.py to either the definitions
or an empty list, always.
-- 
pw-bot: cr