netdev - Re: [PATCH] net :mana : Add per-cpu stats for MANA device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bk7oebxk.fsf@nvidia.com>
Date: Fri, 08 Mar 2024 11:52:42 -0800
From: Rahul Rameshbabu <rrameshbabu@...dia.com>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: Jakub Kicinski <kuba@...nel.org>, Shradha Gupta
 <shradhagupta@...ux.microsoft.com>, Shradha Gupta
 <shradhagupta@...rosoft.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "linux-hyperv@...r.kernel.org"
 <linux-hyperv@...r.kernel.org>, "linux-rdma@...r.kernel.org"
 <linux-rdma@...r.kernel.org>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Ajay Sharma <sharmaajay@...rosoft.com>, Leon
 Romanovsky <leon@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Sebastian Andrzej  Siewior <bigeasy@...utronix.de>, KY Srinivasan
 <kys@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan Cui
 <decui@...rosoft.com>, Long Li <longli@...rosoft.com>, Paul Rosswurm
 <paulros@...rosoft.com>, Alireza Dabagh <alid@...rosoft.com>, Sharath
 George John <sgeorgejohn@...rosoft.com>
Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device


On Fri, 08 Mar, 2024 19:43:57 +0000 Haiyang Zhang <haiyangz@...rosoft.com> wrote:
>> -----Original Message-----
>> From: Jakub Kicinski <kuba@...nel.org>
>> Sent: Friday, March 8, 2024 2:23 PM
>> To: Haiyang Zhang <haiyangz@...rosoft.com>
>> Cc: Shradha Gupta <shradhagupta@...ux.microsoft.com>; Shradha Gupta
>> <shradhagupta@...rosoft.com>; linux-kernel@...r.kernel.org; linux-
>> hyperv@...r.kernel.org; linux-rdma@...r.kernel.org;
>> netdev@...r.kernel.org; Eric Dumazet <edumazet@...gle.com>; Paolo Abeni
>> <pabeni@...hat.com>; Ajay Sharma <sharmaajay@...rosoft.com>; Leon
>> Romanovsky <leon@...nel.org>; Thomas Gleixner <tglx@...utronix.de>;
>> Sebastian Andrzej Siewior <bigeasy@...utronix.de>; KY Srinivasan
>> <kys@...rosoft.com>; Wei Liu <wei.liu@...nel.org>; Dexuan Cui
>> <decui@...rosoft.com>; Long Li <longli@...rosoft.com>; Michael Kelley
>> <mikelley@...rosoft.com>
>> Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device
>> 
>> On Fri, 8 Mar 2024 18:51:58 +0000 Haiyang Zhang wrote:
>> > > Dynamic is a bit of an exaggeration, right? On a well-configured
>> system
>> > > each CPU should use a single queue assigned thru XPS. And for manual
>> > > debug bpftrace should serve the purpose quite well.
>> >
>> > Some programs, like irqbalancer can dynamically change the CPU
>> affinity,
>> > so we want to add the per-CPU counters for better understanding of the
>> CPU
>> > usage.
>> 
>> Do you have experimental data showing this making a difference
>> in production?
> Shradha, could you please add some data before / after enabling irqbalancer 
> which changes cpu affinity?
>
>> 
>> Seems unlikely, but if it does work we should enable it for all
>> devices, no driver by driver.
> There are some existing drivers, like mlx, rmnet, netvsc, etc. using percpu 
> counters. Are you suggesting we add a common API for all drivers?

Wanted to chime in with regards to mlx. You might be conflating per-cpu
with per-queue. When we run ethtool -S, we present counters per netdev
queue rather than per-cpu. The number of queues we instantiate is
related to CPUs but it not always 1-1.

Jakub just recently supported a proper interface for per-queue stats
counters that we are interested in supporting.

  https://lore.kernel.org/netdev/20240222223629.158254-1-kuba@kernel.org/

--
Thanks,

Rahul Rameshbabu