netdev - RE: [EXTERNAL] [PATCH net-next] r8169: switch to new function phy_support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <SJ0PR18MB52166D474EE78BC4E7B6B3E9DB272@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Fri, 8 Mar 2024 07:37:02 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Heiner Kallweit <hkallweit1@...il.com>,
        Realtek linux nic maintainers
	<nic_swsd@...ltek.com>,
        Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski
	<kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net-next] r8169: switch to new function
 phy_support_eee

Hi Heiner,

To me it looks like both patches, 
r8169: switch to new function phy_support_eee and net: phy: simplify a check in phy_check_link_status is related and can be pushed as a series. This will make change more harmonic. Because, you are moving setting of enable_tx_lpi in one patch and removing from the other one.

Regards,
Suman

>-----Original Message-----
>From: Heiner Kallweit <hkallweit1@...il.com>
>Sent: Friday, March 8, 2024 2:53 AM
>To: Realtek linux nic maintainers <nic_swsd@...ltek.com>; Paolo Abeni
><pabeni@...hat.com>; Jakub Kicinski <kuba@...nel.org>; David Miller
><davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>
>Cc: netdev@...r.kernel.org
>Subject: [EXTERNAL] [PATCH net-next] r8169: switch to new function
>phy_support_eee
>Switch to new function phy_support_eee. This allows to simplify the code
>because data->tx_lpi_enabled is now populated by phy_ethtool_get_eee().
>
>Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>---
> drivers/net/ethernet/realtek/r8169_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/net/ethernet/realtek/r8169_main.c
>b/drivers/net/ethernet/realtek/r8169_main.c
>index 0d2cbb32c..5c879a5c8 100644
>--- a/drivers/net/ethernet/realtek/r8169_main.c
>+++ b/drivers/net/ethernet/realtek/r8169_main.c
>@@ -2079,7 +2079,6 @@ static int rtl8169_get_eee(struct net_device *dev,
>struct ethtool_keee *data)
> 		return ret;
>
> 	data->tx_lpi_timer = r8169_get_tx_lpi_timer_us(tp);
>-	data->tx_lpi_enabled = data->tx_lpi_timer ? data->eee_enabled :
>false;
>
> 	return 0;
> }
>@@ -5174,7 +5173,7 @@ static int r8169_mdio_register(struct
>rtl8169_private *tp)
>
> 	tp->phydev->mac_managed_pm = true;
> 	if (rtl_supports_eee(tp))
>-		phy_advertise_eee_all(tp->phydev);
>+		phy_support_eee(tp->phydev);
> 	phy_support_asym_pause(tp->phydev);
>
> 	/* PHY will be woken up in rtl_open() */
>--
>2.44.0
>