netdev - Re: [PATCH net-next v9 6/9] dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEZPR06MB695939C120C504830B04430A96272@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Fri, 8 Mar 2024 16:02:32 +0800
From: Yang Xiwen <forbidden405@...look.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Yisen Zhuang <yisen.zhuang@...wei.com>, Salil Mehta
 <salil.mehta@...wei.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v9 6/9] dt-bindings: net: hisi-femac: add binding
 for Hi3798MV200 FEMAC core

On 3/8/2024 4:01 PM, Krzysztof Kozlowski wrote:
> On 07/03/2024 12:34, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@...look.com>
>>
>> HiSilicon FEMAC core is also found on Hi3798MV200 SoC. Document it in
>> binding.
>>
>> Signed-off-by: Yang Xiwen <forbidden405@...look.com>
>>
>> # Conflicts:
>> #	Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> Drop
>
>> ---
>>   Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
>> index 5cd2331668bc..4f8a07864eb4 100644
>> --- a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
>> +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
>> @@ -16,6 +16,7 @@ properties:
>>     compatible:
>>       enum:
>>         - hisilicon,hi3516cv300-femac
>> +      - hisilicon,hi3798mv200-femac
> As I asked two or three or four times: please express compatibility
> (oneOf, items). Your driver suggests that they are compatible. If they
> are not compatible, mention it in commit msg, but so far it suggests
> they are compatible.

They are compatible as far as i see.

>
> Best regards,
> Krzysztof
>

-- 
Regards,
Yang Xiwen