netdev - RE: [PATCH] nfp: flower: handle acti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR13MB3705982C783811A22D1692F1FC272@DM6PR13MB3705.namprd13.prod.outlook.com>
Date: Fri, 8 Mar 2024 08:39:37 +0000
From: Yinjun Zhang <yinjun.zhang@...igine.com>
To: Duoming Zhou <duoming@....edu.cn>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, oss-drivers
	<oss-drivers@...igine.com>, "christophe.jaillet@...adoo.fr"
	<christophe.jaillet@...adoo.fr>, "horms@...nel.org" <horms@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, Louis Peens <louis.peens@...igine.com>
Subject: RE: [PATCH] nfp: flower: handle acti_netdevs allocation failure

On Thursday, March 7, 2024 9:54 PM, Duoming Zhou wrote:
<...>
> 
>                 acti_netdevs = kmalloc_array(entry->slave_cnt,
>                                              sizeof(*acti_netdevs), GFP_KERNEL);
> +               if (!acti_netdevs) {
> +                       nfp_flower_cmsg_warn(priv->app,
> +                                            "memory allocate failed\n");
> +                       schedule_delayed_work(&lag->work,
> +                                             NFP_FL_LAG_DELAY);
> +                       continue;
> +               }

It reminds me that this issue was reported and tried to fix in
https://lore.kernel.org/netdev/ZVsFBACC05VrrCfw@LouisNoVo/T/#t
However there's no followed v2 to address the review comments.
Based on that discussion, we don't need warn "allocate failed" locally.

> 
>                 /* Include sanity check in the loop. It may be that a bond has
>                  * changed between processing the last notification and the
> --
> 2.17.1