netdev - Re: [net-next 2/2] ravb: Add support for an optional MDIO mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7bb4374-0afa-b79e-e64c-bd97b6680354@omp.ru>
Date: Sat, 9 Mar 2024 22:28:47 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob
 Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, Yoshihiro Shimoda
	<yoshihiro.shimoda.uh@...esas.com>, Biju Das <biju.das.jz@...renesas.com>,
	<netdev@...r.kernel.org>, <devicetree@...r.kernel.org>
CC: <linux-renesas-soc@...r.kernel.org>
Subject: Re: [net-next 2/2] ravb: Add support for an optional MDIO mode

On 3/9/24 6:53 PM, Niklas Söderlund wrote:

> The driver used the OF node of the device itself when registering the

   s/OF/DT/, perhaps?

> MDIO bus. While this works it creates a problem, it forces any MDIO bus

   While this works, it creates a problem: it forces any MDIO bus...

> properties to also be set on the devices OF node. This mixes the

  Again, DT node?

> properties of two distinctly different things and is confusing.
> 
> This change adds support for an optional mdio node to be defined as a
> child to the device OF node. The child node can then be used to describe
> MDIO bus properties that the MDIO core can act on when registering the
> bus.
> 
> If no mdio child node is found the driver fallback to the old behavior
> and register the MDIO bus using the device OF node. This change is
> backward compatible with old bindings in use.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey