netdev - Re: [PATCH] net: macb: remove change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240309145441.GA4701@kernel.org>
Date: Sat, 9 Mar 2024 14:54:41 +0000
From: Simon Horman <horms@...nel.org>
To: thomas.perrot@...tlin.com
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: macb: remove change_mtu callback

On Fri, Mar 08, 2024 at 04:53:30PM +0100, thomas.perrot@...tlin.com wrote:
> From: Thomas Perrot <thomas.perrot@...tlin.com>
> 
> Because it doesn't allow MTU changes when the interface is up, although
> it is not necessary.
> 
> This callback has been added to add in a first implementation of the Jumbo
> support [1],since it has been reworked and moved to the probe [2].
> 
> [1] commit a5898ea09aad ("net: macb: Add change_mtu callback with
>     jumbo support")
> [2] commit 44770e1180de ("ethernet: use core min/max MTU checking")
> 
> Signed-off-by: Thomas Perrot <thomas.perrot@...tlin.com>

Hi Thomas,

Perhaps it is worth mentioning that after this patch the core will set the
MTU, regardless of if the interface is up or not.