netdev - Re: [PATCH net-next v2 1/1] net: bridge: switchdev: Improve error message clarity for switchdev_port_obj_add/del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eeabbfd72b3c3a354838e889ee6602774e67cbef.camel@perches.com>
Date: Sat, 09 Mar 2024 09:14:50 -0800
From: Joe Perches <joe@...ches.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Jiri Pirko <jiri@...nulli.us>,
  Ivan Vecera <ivecera@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Andrew Lunn <andrew@...n.ch>,  Eric Dumazet <edumazet@...gle.com>, Florian
 Fainelli <f.fainelli@...il.com>, Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>, Vladimir Oltean <olteanv@...il.com>, Simon
 Horman <horms@...nel.org>,  kernel@...gutronix.de,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/1] net: bridge: switchdev: Improve error
 message clarity for switchdev_port_obj_add/del_deffered operations

On Sat, 2024-03-09 at 09:09 -0800, Stephen Hemminger wrote:
> On Sat, 09 Mar 2024 06:26:28 -0800
> Joe Perches <joe@...ches.com> wrote:
> 
> > > +		problem = "Attempted operation is undefined, indicating a "
> > > +			  "possible programming error.\n";  
> > 
> > My preference would be to write
> > 		problem = "Attempted operation is undefined indicating a possible programming error\n";
> 
> ETOOWORDY.
> Be concise please.
> 		problem = "Operations is undefined\n";
> 

Concision is good, plurality matching is too.