[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cb8f85de-c1cd-4742-b8a4-2533482ee3b6@linaro.org>
Date: Sun, 10 Mar 2024 09:44:45 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Niklas Söderlund
<niklas.soderlund+renesas@...natech.se>, Sergey Shtylyov
<s.shtylyov@....ru>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
Biju Das <biju.das.jz@...renesas.com>, netdev@...r.kernel.org,
devicetree@...r.kernel.org
Cc: linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next 1/2] dt-bindings: net: renesas,etheravb: Add optional
MDIO bus node
On 09/03/2024 16:53, Niklas Söderlund wrote:
> The Renesas Ethernet AVB bindings do not allow the MDIO bus to be
> described. This has not been needed as only a single PHY is
> supported and no MDIO bus properties have been needed.
>
> Add an optional mdio node to the binding which allows the MDIO bus to be
> described and allow bus properties to be set.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> ---
I believe this is v2. Mark your patchsets clearly (git format-patch -v2
or use b4) and provide changelog under --- or in the cover letter.
> Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> index de7ba7f345a9..5345ad8e1be4 100644
> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> @@ -93,6 +93,10 @@ properties:
> description: Number of size cells on the MDIO bus.
> const: 0
>
> + mdio:
> + $ref: /schemas/net/mdio.yaml#
> + unevaluatedProperties: false
> +
Please fixup the phy pattern, so it will be obvious it is for
ethernet-phy and probably deprecate it. The phy goes to mdio bus, right?
Best regards,
Krzysztof
Powered by blists - more mailing lists