[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c12687e1-88a3-4ad8-ac39-731a5724ae22@nvidia.com>
Date: Sun, 10 Mar 2024 08:10:10 -0700
From: William Tu <witu@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, jiri@...dia.com, bodong@...dia.com
Subject: Re: [PATCH net-next] Documentation: Add documentation for eswitch
attribute
On 3/8/24 8:14 PM, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, 8 Mar 2024 02:01:06 +0200 William Tu wrote:
>> + * - ``mode``
>> + - enum
>> + - The mode of the device. The mode can be one of the following:
>> +
>> + * ``legacy`` Legacy SRIOV.
>> + * ``switchdev`` SRIOV switchdev offloads.
> In my head `mode` is special because it controls on / off for
> switchdev, and none of the other attrs do anything outside of
> switchdev mode. But thinking about it now, I'm not sure if that's
> actually the case. Let's clarify. And if other attrs indeed are
> only meaningful in switchdev mode we should feature `mode` more
> prominently than others. Separate section perhaps?
got it, will check their dependencies and put in doc.
> Please link to representors.rst and perhaps switchdev.rst ?
> --
OK
William
Powered by blists - more mailing lists