netdev - Re: [devel-ipsec] [RFC ipsec-next v2 0/8] Add IP-TFS mode to xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ze4ZPkyhKiMb6kSP@Antony2201.local>
Date: Sun, 10 Mar 2024 21:34:06 +0100
From: Antony Antony <antony@...nome.org>
To: Christian Hopps <chopps@...pps.org>
Cc: Antony Antony <antony@...nome.org>, devel@...ux-ipsec.org,
	netdev@...r.kernel.org, Christian Hopps <chopps@...n.net>,
	Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [devel-ipsec] [RFC ipsec-next v2 0/8] Add IP-TFS mode to xfrm

On Thu, Mar 07, 2024 at 06:05:37AM -0500, Christian Hopps wrote:
> 
> Antony Antony <antony@...nome.org> writes:
> 
> > On Sun, Nov 12, 2023 at 10:52:11PM -0500, Christian Hopps via Devel wrote:
> > > From: Christian Hopps <chopps@...n.net>
> > > 

> > b: In xfrm_state_construct():
> > 
> > if (attrs[XFRMA_TFCPAD])
> >     x->tfcpad = nla_get_u32(attrs[XFRMA_TFCPAD]);
> 
> Can you explain this more?

I haven't used it. I just know it from *swan code. And I wondered how it 
would work with IP-TFS. Looking in the kernel code, I noticed, it is not 
allowed in xfrm_user.c

 270                 if (attrs[XFRMA_TFCPAD] &&
 271                     p->mode != XFRM_MODE_TUNNEL) {
 272                         NL_SET_ERR_MSG(extack, "TFC padding can only be used in tunnel mode");
 273                         goto out;
 274                 }