netdev - Re: [PATCH net-next 3/3] genetlink: remove linux/genetlink.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4554322.LvFx2qVVIh@sven-l14>
Date: Sun, 10 Mar 2024 08:22:35 +0100
From: Sven Eckelmann <sven@...fation.org>
To: davem@...emloft.net, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 jiri@...nulli.us, Jakub Kicinski <kuba@...nel.org>, Jason@...c4.com,
 mareklindner@...mailbox.ch, sw@...onwunderlich.de, a@...table.cc,
 pshelar@....org, andriy.shevchenko@...ux.intel.com,
 wireguard@...ts.zx2c4.com, dev@...nvswitch.org
Subject: Re: [PATCH net-next 3/3] genetlink: remove linux/genetlink.h

On Saturday, 9 March 2024 19:34:58 CET Jakub Kicinski wrote:
> genetlink.h is a shell of what used to be a combined uAPI
> and kernel header over a decade ago. It has fewer than
> 10 lines of code. Merge it into net/genetlink.h.
> In some ways it'd be better to keep the combined header
> under linux/ but it would make looking through git history
> harder.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
[...]
> diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
> index 75119f1ffccc..8e0f44c71696 100644
> --- a/net/batman-adv/main.c
> +++ b/net/batman-adv/main.c
> @@ -14,7 +14,6 @@
>  #include <linux/crc32c.h>
>  #include <linux/device.h>
>  #include <linux/errno.h>
> -#include <linux/genetlink.h>
>  #include <linux/gfp.h>
>  #include <linux/if_ether.h>
>  #include <linux/if_vlan.h>
> @@ -38,6 +37,7 @@
>  #include <linux/string.h>
>  #include <linux/workqueue.h>
>  #include <net/dsfield.h>
> +#include <net/genetlink.h>
>  #include <net/rtnetlink.h>
>  #include <uapi/linux/batadv_packet.h>
>  #include <uapi/linux/batman_adv.h>
> diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
> index 0954757f0b8b..9362cd9d6f3d 100644
> --- a/net/batman-adv/netlink.c
> +++ b/net/batman-adv/netlink.c
> @@ -15,7 +15,6 @@
>  #include <linux/cache.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> -#include <linux/genetlink.h>
>  #include <linux/gfp.h>
>  #include <linux/if_ether.h>
>  #include <linux/if_vlan.h>


Acked-by: Sven Eckelmann <sven@...fation.org>

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)