netdev - Re: [PATCH net-next 11/11] selftests: forwarding: Add a test for NH group stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734swlmjh.fsf@nvidia.com>
Date: Mon, 11 Mar 2024 17:30:54 +0100
From: Petr Machata <petrm@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, Ido Schimmel <idosch@...dia.com>, David Ahern
	<dsahern@...nel.org>, Shuah Khan <shuah@...nel.org>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next 11/11] selftests: forwarding: Add a test for NH
 group stats


Jakub Kicinski <kuba@...nel.org> writes:

> On Mon, 11 Mar 2024 12:00:59 +0100 Petr Machata wrote:
>> > It should run the SW parts and skip the HW ones.  
>> 
>> In fact why don't I paste the run I still have in the terminal from last
>> week:
>> 
>> [root@...tme-ng forwarding]# TESTS=" nh_stats_test_v4 nh_stats_test_v6 " ./router_mpath_nh_res.sh
>> TEST: NH stats test IPv4                                            [ OK ]
>> TEST: HW stats not offloaded on veth topology                       [SKIP]
>> TEST: NH stats test IPv6                                            [ OK ]
>> TEST: HW stats not offloaded on veth topology                       [SKIP]
>
> SKIP beats PASS so the result for the entire test (according to our
> local result parser) will be SKIP. Can we switch to XFAIL?

Sure.

But I don't think SKIP should trump PASS. IMHO SKIP is the weakest
status, soon as you have one PASS, that's what the overall outcome
should be. I guess the logic behind it was that it's useful to see the
tests that skip?