netdev - Re: [PATCH net] devlink: Fix length of eswitch inline-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ze7CJDNDicurMYGS@nanopsycho>
Date: Mon, 11 Mar 2024 09:34:44 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: William Tu <witu@...dia.com>
Cc: netdev@...r.kernel.org, jiri@...dia.com, bodong@...dia.com
Subject: Re: [PATCH net] devlink: Fix length of eswitch inline-mode

Sun, Mar 10, 2024 at 05:45:47PM CET, witu@...dia.com wrote:
>Set eswitch inline-mode to be u8, not u16. Otherwise, errors below
>
>$ devlink dev eswitch set pci/0000:08:00.0 mode switchdev \
>  inline-mode network
>    Error: Attribute failed policy validation.
>    kernel answers: Numerical result out of rang
>    netlink: 'devlink': attribute type 26 has an invalid length.
>
>Fixes: f2f9dd164db0 ("netlink: specs: devlink: add the remaining command to generate complete split_ops")

Oops. I wonder if I messed anything else.

Reviewed-by: Jiri Pirko <jiri@...dia.com>

Thanks!


>Signed-off-by: William Tu <witu@...dia.com>
>---
>Or we can fix the iproute2 to use u16?

Nope, this is UAPI.