netdev - Re: [PATCH iproute2-next 1/4] libnetlink: Add rta_getattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87jzm9kpc4.fsf@nvidia.com>
Date: Mon, 11 Mar 2024 11:53:50 +0100
From: Petr Machata <petrm@...dia.com>
To: Stephen Hemminger <stephen@...workplumber.org>
CC: Jakub Kicinski <kuba@...nel.org>, Petr Machata <petrm@...dia.com>, "David
 Ahern" <dsahern@...nel.org>, <netdev@...r.kernel.org>, Ido Schimmel
	<idosch@...dia.com>, <mlxsw@...dia.com>
Subject: Re: [PATCH iproute2-next 1/4] libnetlink: Add rta_getattr_uint()


Stephen Hemminger <stephen@...workplumber.org> writes:

> On Fri, 8 Mar 2024 19:43:34 -0800
> Jakub Kicinski <kuba@...nel.org> wrote:
>
>> On Fri, 8 Mar 2024 14:58:59 -0800 Stephen Hemminger wrote:
>> > > +static inline __u64 rta_getattr_uint(const struct rtattr *rta)
>> > > +{
>> > > +	if (RTA_PAYLOAD(rta) == sizeof(__u32))
>> > > +		return rta_getattr_u32(rta);
>> > > +	return rta_getattr_u64(rta);    
>> > 
>> > Don't understand the use case here.
>> > The kernel always sends the same payload size for the same attribute.  
>> 
>> Please see commit 374d345d9b5e13380c in the kernel.
>
> Ok, but maybe go further and handle u16 and u8

I intended this as a getter of the corresponding kernel attribute type,
which only ever sends 4- and 8-byte payloads, but sure, I can add that.