netdev - RE: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic .ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 11 Mar 2024 11:36:14 +0000
From: Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
To: Breno Leitao <leitao@...ian.org>, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo
 Abeni <pabeni@...hat.com>
CC: "keescook@...omium.org" <keescook@...omium.org>,
        Ido Schimmel
	<idosch@...dia.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        Amit Cohen
	<amcohen@...dia.com>, Petr Machata <petrm@...dia.com>,
        Jiri Benc
	<jbenc@...hat.com>, Beniamino Galvani <b.galvani@...il.com>,
        Gavin Li
	<gavinl@...dia.com>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic
 .ndo_get_stats64



>-----Original Message-----
>From: Breno Leitao <leitao@...ian.org>
>Sent: Monday, March 11, 2024 4:55 PM
>To: David S. Miller <davem@...emloft.net>; Eric Dumazet
><edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
><pabeni@...hat.com>
>Cc: keescook@...omium.org; Ido Schimmel <idosch@...dia.com>; Nikolay
>Aleksandrov <razor@...ckwall.org>; Amit Cohen <amcohen@...dia.com>; Petr
>Machata <petrm@...dia.com>; Jiri Benc <jbenc@...hat.com>; Beniamino
>Galvani <b.galvani@...il.com>; Gavin Li <gavinl@...dia.com>; open
>list:NETWORKING DRIVERS <netdev@...r.kernel.org>; open list <linux-
>kernel@...r.kernel.org>
>Subject: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic
>.ndo_get_stats64
>
>Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
>configured") moved the callback to dev_get_tstats64() to net core, so,
>unless the driver is doing some custom stats collection, it does not
>need to set .ndo_get_stats64.
>
>Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
>doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
>function pointer.
>
>Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Subbaraya Sundeep <sbhatta@...vell.com>
...