netdev - Re: [PATCH net] vmxnet3: Fix missing reserved tailroom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D33EF776-A902-43A7-82DF-7D7B43608EED@gmail.com>
Date: Tue, 12 Mar 2024 13:39:36 +0200
From: Martin Zaharinov <micron10@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: William Tu <witu@...dia.com>,
 netdev <netdev@...r.kernel.org>,
 William Tu <u9012063@...il.com>,
 Alexander Duyck <alexanderduyck@...com>,
 "<alexandr.lobakin@...el.com> <;hawk@...nel.org>" <daniel@...earbox.net>,
 bpf@...r.kernel.org,
 john.fastabend@...il.com,
 pv-drivers@...are.com,
 doshir@...are.com
Subject: Re: [PATCH net] vmxnet3: Fix missing reserved tailroom

Hi Paolo,

Patch tested and work fine without any error.
tested on latest 6.7.9 kernel 
m.

> On 12 Mar 2024, at 12:56, Paolo Abeni <pabeni@...hat.com> wrote:
> 
> On Sat, 2024-03-09 at 20:31 +0200, William Tu wrote:
>> Use rbi->len instead of rcd->len for non-dataring packet.
>> 
>> Found issue:
>>  XDP_WARN: xdp_update_frame_from_buff(line:278): Driver BUG: missing reserved tailroom
>>  WARNING: CPU: 0 PID: 0 at net/core/xdp.c:586 xdp_warn+0xf/0x20
>>  CPU: 0 PID: 0 Comm: swapper/0 Tainted: G        W  O       6.5.1 #1
>>  RIP: 0010:xdp_warn+0xf/0x20
>>  ...
>>  ? xdp_warn+0xf/0x20
>>  xdp_do_redirect+0x15f/0x1c0
>>  vmxnet3_run_xdp+0x17a/0x400 [vmxnet3]
>>  vmxnet3_process_xdp+0xe4/0x760 [vmxnet3]
>>  ? vmxnet3_tq_tx_complete.isra.0+0x21e/0x2c0 [vmxnet3]
>>  vmxnet3_rq_rx_complete+0x7ad/0x1120 [vmxnet3]
>>  vmxnet3_poll_rx_only+0x2d/0xa0 [vmxnet3]
>>  __napi_poll+0x20/0x180
>>  net_rx_action+0x177/0x390
>> 
>> Reported-by: Martin Zaharinov <micron10@...il.com>
>> Tested-by: Martin Zaharinov <micron10@...il.com>
>> Link: https://lore.kernel.org/netdev/74BF3CC8-2A3A-44FF-98C2-1E20F110A92E@gmail.com/
>> Fixes: 54f00cce1178 ("vmxnet3: Add XDP support.")
>> Signed-off-by: William Tu <witu@...dia.com>
>> ---
>> Note: this is a while ago in 2023, I forgot to send.
>> https://lore.kernel.org/netdev/74BF3CC8-2A3A-44FF-98C2-1E20F110A92E@gmail.com/
> 
> The patch LGTM, but you omitted a quite long list of relevant
> recipients, added now. Let's wait a bit more for some feedback.
> 
> Cheers,
> 
> Paolo