netdev - Re: [PATCH 2/3] net: marvell: prestera: fix memory use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240312164526.4a0e242a@kmaincent-XPS-13-7390>
Date: Tue, 12 Mar 2024 16:45:26 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Elad Nachman <enachman@...vell.com>
Cc: <taras.chornyi@...ision.eu>, <davem@...emloft.net>,
 <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
 <andrew@...n.ch>, <thomas.petazzoni@...tlin.com>,
 <miquel.raynal@...tlin.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] net: marvell: prestera: fix memory use after free

On Mon, 11 Mar 2024 15:51:11 +0200
Elad Nachman <enachman@...vell.com> wrote:

> From: Elad Nachman <enachman@...vell.com>
> 
> Prestera driver routing module cleanup process would
> release memory and then reference it again, and eventually
> free it again.
> Remove the redundant first memory free call.
> All such double free calls were detected using KASAN.
 
Not directly related to this patch but I am wondering if
the call to prestera_port_sfp_unbind(port) is not missing in
prestera_destroy_ports() function?

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com