netdev - Re: [Intel-wired-lan] [PATCH 1/1] idpf: Clean up the vmvf_type for ctlq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90885522-c035-4ed5-9971-e2a7fc94ef19@intel.com>
Date: Tue, 12 Mar 2024 08:05:40 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Zhu Yanjun <yanjun.zhu@...el.com>, <anthony.l.nguyen@...el.com>
CC: <jesse.brandeburg@...el.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <netdev@...r.kernel.org>,
	<intel-wired-lan@...ts.osuosl.org>, <pabeni@...hat.com>, <kuba@...nel.org>,
	Zhu Yanjun <yanjun.zhu@...ux.dev>
Subject: Re: [Intel-wired-lan] [PATCH 1/1] idpf: Clean up the vmvf_type for
 ctlq_recv functions

On 3/12/24 07:15, Zhu Yanjun wrote:
> From: Zhu Yanjun <yanjun.zhu@...ux.dev>
> 
> In the original source code, add vmvf_type to ctrl_msg for ctlq_recv
> functions. These new types will be implemented and used. But currently
> these types are not used. So remove them.

This commit message is hard to read.
Also please try to use imperative mood, and avoid phrases like "this 
commit", "in the code", as most likely those are implicit.

Please also wait with your contribution for next window opening.

For Intel Employees this internal wiki could be useful:
https://wiki.ith.intel.com/display/LADSW/Common+faults+when+sending+%28a+first%29+series+upstream

> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...ux.dev>
> ---
>   drivers/net/ethernet/intel/idpf/idpf_controlq_api.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h b/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
> index 8dee098bbfb0..e1b6ee87ad95 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
> @@ -37,9 +37,6 @@ struct idpf_ctlq_reg {
>   /* Generic queue msg structure */
>   struct idpf_ctlq_msg {
>   	u8 vmvf_type; /* represents the source of the message on recv */
> -#define IDPF_VMVF_TYPE_VF 0
> -#define IDPF_VMVF_TYPE_VM 1
> -#define IDPF_VMVF_TYPE_PF 2
>   	u8 host_id;
>   	/* 3b field used only when sending a message to CP - to be used in
>   	 * combination with target func_id to route the message