[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240313153437.124749-1-m.lobanov@rosalinux.ru>
Date: Wed, 13 Mar 2024 11:34:36 -0400
From: Mikhail Lobanov <m.lobanov@...alinux.ru>
To: Raju Rangoju <rajur@...lsio.com>
Cc: Mikhail Lobanov <m.lobanov@...alinux.ru>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
netdev@...r.kernel.org (open list:CXGB4 ETHERNET DRIVER (CXGB4)),
linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] cxgb4: unnecessary check for 0 in the free_sge_txq_uld() function
The free_sge_txq_old() function has an unnecessary txq check of 0.
This check is not necessary, since the txq pointer is initialized by the
uldtxq[i] address from the operation &txq_info->uldtxq[i], which ensures
that txq is not equal to 0.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: ab677ff4ad15 ("cxgb4: Allocate Tx queues dynamically")
Signed-off-by: Mikhail Lobanov <m.lobanov@...alinux.ru>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
index 17faac715882..5c13bcb4550d 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
@@ -406,7 +406,7 @@ free_sge_txq_uld(struct adapter *adap, struct sge_uld_txq_info *txq_info)
for (i = 0; i < nq; i++) {
struct sge_uld_txq *txq = &txq_info->uldtxq[i];
- if (txq && txq->q.desc) {
+ if (txq->q.desc) {
tasklet_kill(&txq->qresume_tsk);
t4_ofld_eq_free(adap, adap->mbox, adap->pf, 0,
txq->q.cntxt_id);
--
2.43.0
Powered by blists - more mailing lists