netdev - RE: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 13 Mar 2024 20:34:10 +0000
From: <Ronnie.Kunin@...rochip.com>
To: <andrew@...n.ch>, <f.fainelli@...il.com>
CC: <Raju.Lakkaraju@...rochip.com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <kuba@...nel.org>, <linux-kernel@...r.kernel.org>,
	<Bryan.Whitehead@...rochip.com>, <richardcochran@...il.com>,
	<UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net 3/3] net: lan743x: Address problems with wake option
 flags configuration sequences


> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Wednesday, March 13, 2024 3:53 PM
> To: Florian Fainelli <f.fainelli@...il.com>
> Cc: Ronnie Kunin - C21729 <Ronnie.Kunin@...rochip.com>; Raju Lakkaraju - I30499
> <Raju.Lakkaraju@...rochip.com>; netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org;
> linux-kernel@...r.kernel.org; Bryan Whitehead - C21958 <Bryan.Whitehead@...rochip.com>;
> richardcochran@...il.com; UNGLinuxDriver <UNGLinuxDriver@...rochip.com>
> Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration
> sequences
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> So i think we need to agree on best practices for new drivers and document what that is, probably in
> both the ethtool man page and include/uapi/linux/ethtool.h
> 
> * WAKE_MAGIC on its own is O.K.
> * WAKE_MAGICSECURE without WAKE_MAGIC is invalid. -EINVAL
> * WAKE_MAGIC + WAKE_MAGICSECURE means only secure magic WoL.
> * Each driver needs to enforce this, due to backwards compatibility.
>   Some may decide not to.
> 
> Can we agree on this?

Sounds good to me.
Raju (and other MCHP folks) are out this week due to a company shutdown, but he should be able to submit a new patch for lan743x as described above when back next week.

> 
>     Andrew