netdev - Re: [devel-ipsec] [PATCH ipsec-next v4] xfrm: Add Direction to the SA in or out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2b3203b-fcc7-452f-88d8-1ef826509915@6wind.com>
Date: Thu, 14 Mar 2024 15:28:57 +0100
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: antony.antony@...unet.com, Steffen Klassert
 <steffen.klassert@...unet.com>, Herbert Xu <herbert@...dor.apana.org.au>
Cc: devel@...ux-ipsec.org, netdev@...r.kernel.org
Subject: Re: [devel-ipsec] [PATCH ipsec-next v4] xfrm: Add Direction to the SA
 in or out

Le 13/03/2024 à 22:04, Antony Antony via Devel a écrit :
> This patch introduces the 'dir' attribute, 'in' or 'out', to the
> xfrm_state, SA, enhancing usability by delineating the scope of values
> based on direction. An input SA will now exclusively encompass values
> pertinent to input, effectively segregating them from output-related
> values. This change aims to streamline the configuration process and
> improve the overall clarity of SA attributes.

If I correctly understand the commit, the direction is ignored if there is no
offload configured, ie an output SA could be used in input. Am I right?

If yes:
 1/ it would be nice to state it explicitly in the commit log.
 2/ it is confusing for users not using offload.

Regards,
Nicolas

> 
> Signed-off-by: Antony Antony <antony.antony@...unet.com>