netdev - Re: [PATCH net] packet: annotate data-races around ignore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJVrZ0bT2V0VkmhNnfe=uOruOMWvaya_WcNe-JmtAJSgw@mail.gmail.com>
Date: Thu, 14 Mar 2024 16:43:53 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com, 
	syzbot+c669c1136495a2e7c31f@...kaller.appspotmail.com
Subject: Re: [PATCH net] packet: annotate data-races around ignore_outgoing

On Thu, Mar 14, 2024 at 4:33 PM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> Should we also include a WRITE_ONCE on the fanout prot_hook:
>
>         match->prot_hook.ignore_outgoing = type_flags & PACKET_FANOUT_FLAG_IGNORE_OUTGOING;

This is not needed, the variable is not yet visible by other cpus.