[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240314110553.1c5310c9@kernel.org>
Date: Thu, 14 Mar 2024 11:05:53 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc: ahmed.zaki@...el.com, aleksander.lobakin@...el.com,
alexandre.torgue@...s.st.com, andrew@...n.ch, corbet@....net,
davem@...emloft.net, dtatulea@...dia.com, edumazet@...gle.com,
gal@...dia.com, hkallweit1@...il.com, jacob.e.keller@...el.com,
jiri@...nulli.us, joabreu@...opsys.com, justinstitt@...gle.com,
kory.maincent@...tlin.com, leon@...nel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, liuhangbin@...il.com,
maxime.chevallier@...tlin.com, netdev@...r.kernel.org, pabeni@...hat.com,
paul.greenwalt@...el.com, przemyslaw.kitszel@...el.com,
rdunlap@...radead.org, richardcochran@...il.com, saeed@...nel.org,
tariqt@...dia.com, vadim.fedorenko@...ux.dev, vladimir.oltean@....com,
wojciech.drewek@...el.com
Subject: Re: [PATCH RFC v2 6/6] tools: ynl: ethtool.py: Output timestamping
statistics from tsinfo-get operation
On Wed, 13 Mar 2024 23:07:22 -0700 Rahul Rameshbabu wrote:
> What's your expectation for how the request structure would look like? I
> have tried the following.
>
> if args.show_time_stamping:
> req = {
> 'header': {
> 'flags': 'stats',
> },
> }
>
> if args.show_time_stamping:
> req = {
> 'header': {
> 'flags': {
> 'stats': True,
> },
> },
> }
>
> I tried looking through the lib/ynl.py code, but I did not understand
> how the 'flags' type was specifically handled.
Rebased on latest net-next?
I used this:
./tools/net/ynl/cli.py \
--spec Documentation/netlink/specs/ethtool.yaml \
--do fec-get --json '{"header":{"dev-index": 2, "flags": "stats"}}'
Powered by blists - more mailing lists