netdev - Re: [PATCH net-next v1] Revert "net: Re-use and set mono_delivery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb6094d1-0d36-4e28-9a5f-df33466778f0@quicinc.com>
Date: Wed, 13 Mar 2024 17:37:09 -0700
From: "Abhishek Chauhan (ABC)" <quic_abchauha@...cinc.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Andrew Halaney
	<ahalaney@...hat.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Martin KaFai Lau <martin.lau@...nel.org>,
        Martin KaFai Lau
	<martin.lau@...ux.dev>,
        Daniel Borkmann <daniel@...earbox.net>, <kernel@...cinc.com>
Subject: Re: [PATCH net-next v1] Revert "net: Re-use and set
 mono_delivery_time bit for userspace tstamp packets"



On 3/13/2024 5:16 PM, Jakub Kicinski wrote:
> On Wed, 13 Mar 2024 16:50:03 -0700 Abhishek Chauhan wrote:
>> Subject: [PATCH net-next v1] Revert "net: Re-use and set mono_delivery_time bit for userspace tstamp packets"
>> Date: Wed, 13 Mar 2024 16:50:03 -0700
>> X-Mailer: git-send-email 2.25.1
>>
>> This reverts commit 30bb896b98fce7d823a96fc02cd69be30384a5cc.
>>
>> Signed-off-by: Abhishek Chauhan <quic_abchauha@...cinc.com>
>> ---
>> Reason for revert - 
>> https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/
> 
>> 1. Fallback to design proposed in version 1 to have a seperate user_delivery_time
>> bit 
>> 2. Keep mono_delivery_time as ease
>> 3. Add user_delivery_time as a new bitfield will be a seperate patch 
>> 4. do not reset the time if either mono_delivery_time or user_delivery_time is set
>> 5. we will need a user_delivery_time bit and use that to look at sk_clockid
> 
> Could you please spell this out a bit more in the commit message and
> add the link as a:
> 

Certainly i can do that and explain more in the Revert commit message and point a link as mentioned 
below as why we need to fall back to design 1 proposal for adding an extra bit. 
> Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/
> 
> in the commit message rather than the "throw away notes" ?
> 
> (feel free to repost asap, without usual netdev's 24h)