netdev - Re: [PATCH v7 1/5] net: wan: Add support for QMC HDLC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r0gd2iju.fsf@mail.lhotse>
Date: Thu, 14 Mar 2024 21:51:01 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Yury Norov
 <yury.norov@...il.com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, Andrew Lunn
 <andrew@...n.ch>, Mark Brown <broonie@...nel.org>, Ratheesh Kannoth
 <rkannoth@...vell.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v7 1/5] net: wan: Add support for QMC HDLC

Herve Codina <herve.codina@...tlin.com> writes:
> Hi Michael,
>
> On Thu, 14 Mar 2024 10:05:37 +1100
> Michael Ellerman <mpe@...erman.id.au> wrote:
>
>> Hi Herve,
>> 
>> Herve Codina <herve.codina@...tlin.com> writes:
> ..
>> This breaks when building as a module (eg. ppc32_allmodconfig):
>> 
>>   In file included from ../include/linux/device/driver.h:21,
>>                    from ../include/linux/device.h:32,
>>                    from ../include/linux/dma-mapping.h:8,
>>                    from ../drivers/net/wan/fsl_qmc_hdlc.c:13:
>>   ../drivers/net/wan/fsl_qmc_hdlc.c:405:25: error: ‘qmc_hdlc_driver’ undeclared here (not in a function); did you mean ‘qmc_hdlc_probe’?
>>     405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
>>         |                         ^~~~~~~~~~~~~~~
>> 
>> 
>> IIUIC it should be pointing to the table, not the driver, so:
>> 
>> diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hdlc.c
>> index 5fd7ed325f5b..705c3681fb92 100644
>> --- a/drivers/net/wan/fsl_qmc_hdlc.c
>> +++ b/drivers/net/wan/fsl_qmc_hdlc.c
>> @@ -402,7 +402,7 @@ static const struct of_device_id qmc_hdlc_id_table[] = {
>>         { .compatible = "fsl,qmc-hdlc" },
>>         {} /* sentinel */
>>  };
>> -MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
>> +MODULE_DEVICE_TABLE(of, qmc_hdlc_id_table);
>> 
>>  static struct platform_driver qmc_hdlc_driver = {
>>         .driver = {
>> 
>> 
>> Which then builds correctly.
>
> My bad, I missed that one.
> I fully agree with your modification.
>
> Do you want me to make a patch (copy/paste of your proposed modification)
> or do you plan to send the patch on your side ?

Yes if you can please turn it into a proper patch and submit it.

No need to add my SoB, it's trivial.

cheers