[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240313174707.38a71c84@kernel.org>
Date: Wed, 13 Mar 2024 17:47:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc: ahmed.zaki@...el.com, aleksander.lobakin@...el.com,
alexandre.torgue@...s.st.com, andrew@...n.ch, corbet@....net,
davem@...emloft.net, dtatulea@...dia.com, edumazet@...gle.com,
gal@...dia.com, hkallweit1@...il.com, jacob.e.keller@...el.com,
jiri@...nulli.us, joabreu@...opsys.com, justinstitt@...gle.com,
kory.maincent@...tlin.com, leon@...nel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, liuhangbin@...il.com,
maxime.chevallier@...tlin.com, netdev@...r.kernel.org, pabeni@...hat.com,
paul.greenwalt@...el.com, przemyslaw.kitszel@...el.com,
rdunlap@...radead.org, richardcochran@...il.com, saeed@...nel.org,
tariqt@...dia.com, vadim.fedorenko@...ux.dev, vladimir.oltean@....com,
wojciech.drewek@...el.com
Subject: Re: [PATCH RFC v2 6/6] tools: ynl: ethtool.py: Output timestamping
statistics from tsinfo-get operation
On Wed, 13 Mar 2024 17:22:50 -0700 Rahul Rameshbabu wrote:
> I think this is for 'flag' type attributes. Not for the "header" flags
> for the ethtool request, so I believe this cannot be done here, since
> the header flags are a u32 type, not a flag type.
>
> https://lore.kernel.org/netdev/20240222134351.224704-2-jiri@resnulli.us/
>
> -
> name: header
> attributes:
> -
> name: dev-index
> type: u32
> -
> name: dev-name
> type: string
> -
> name: flags
> type: u32
>
> vs
>
> -
> name: bitset-bit
> attributes:
> -
> name: index
> type: u32
> -
> name: name
> type: string
> -
> name: value
> type: flag
>
> So I believe Jiri's change applies for the latter, not the former (could
> be wrong here).
Ah, we're missing the enum definition and linking :S
I mean:
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 197208f419dc..e1626c94d93b 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -16,6 +16,10 @@ doc: Partial family for Ethtool Netlink.
name: stringset
type: enum
entries: []
+ -
+ name: header-flags
+ type: flags
+ entries: [ compact-bitset, omit-reply, stats ]
attribute-sets:
-
@@ -30,6 +34,7 @@ doc: Partial family for Ethtool Netlink.
-
name: flags
type: u32
+ enum: header-flags
-
name: bitset-bit
See if that works and feel free to post it with my suggested-by
Powered by blists - more mailing lists