netdev - Re: [PATCH net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfSJ+08L+Tr3zeGU@localhost.localdomain>
Date: Fri, 15 Mar 2024 18:48:43 +0100
From: Michal Kubiak <michal.kubiak@...el.com>
To: Jijie Shao <shaojijie@...wei.com>
CC: <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <shenjian15@...wei.com>, <wangjie125@...wei.com>,
	<liuyonglong@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 2/3] net: hns3: fix kernel crash when devlink reload
 during pf initialization

On Fri, Mar 15, 2024 at 06:07:47PM +0800, Jijie Shao wrote:
> From: Yonglong Liu <liuyonglong@...wei.com>
> 
> The devlink reload process will access the hardware resources,
> but the register operation is before the hardware initialize
> done, so, if process the devlink reload during initializetion,

typo: initializetion -> initialization
Moreover, I would suggest to fix the syntax of that description because
it seems to be not obvious.

e.g. the register operation is done before the hardware is initialized
(but I may not get your intention)

> may lead the kernel crash. This patch check whether the NIC is

-> may lead to kernel crash

> initialized to fix the problem.

Maybe just: "Fix this by adding the check if the NIC initialization check" ?

> 
> Fixes: b741269b2759 ("net: hns3: add support for registering devlink for PF")
> Signed-off-by: Yonglong Liu <liuyonglong@...wei.com>
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
> index 9a939c0b217f..80db4f7b05f6 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
> @@ -40,8 +40,9 @@ static int hclge_devlink_reload_down(struct devlink *devlink, bool netns_change,
>  	struct pci_dev *pdev = hdev->pdev;
>  	int ret;
>  
> -	if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state)) {
> -		dev_err(&pdev->dev, "reset is handling\n");
> +	if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state) ||
> +	    !test_bit(HCLGE_STATE_NIC_REGISTERED, &hdev->state)) {
> +		dev_err(&pdev->dev, "reset is handling or driver removed\n");
>  		return -EBUSY;
>  	}
>  
> -- 
> 2.30.0
> 
> 


Thanks,
Michal