netdev - Re: [PATCH net v3] i40e: Enforce software interrupt during busy-poll exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26841417-aee6-a996-4602-fcc00875d604@intel.com>
Date: Fri, 15 Mar 2024 14:31:22 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Ivan Vecera <ivecera@...hat.com>, <netdev@...r.kernel.org>
CC: <pawel.chmielewski@...el.com>, <aleksandr.loktionov@...el.com>,
	<mschmidt@...hat.com>, Hugo Ferreira <hferreir@...hat.com>, Jesse Brandeburg
	<jesse.brandeburg@...el.com>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Jacob Keller <jacob.e.keller@...el.com>, "moderated
 list:INTEL ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org>, open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v3] i40e: Enforce software interrupt during busy-poll
 exit

On 3/15/2024 2:20 AM, Ivan Vecera wrote:

...

> -static inline u32 i40e_buildreg_itr(const int type, u16 itr)
> +/**
> + * i40e_buildreg_itr - build a value for writing to I40E_PFINT_DYN_CTLN register
> + * @itr_idx - interrupt throttling index
> + * @interval - interrupt throttling interval value in usecs
> + * @force_swint - force software interrupt

nit: kdoc doesn't like this style

New warnings added
1a2,4
 > drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function 
parameter or struct member 'itr_idx' not described in 'i40e_buildreg_itr'
 > drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function 
parameter or struct member 'interval' not described in 'i40e_buildreg_itr'
 > drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function 
parameter or struct member 'force_swint' not described in 
'i40e_buildreg_itr'
Per-file breakdown

Thanks,
Tony

> + *
> + * The function builds a value for I40E_PFINT_DYN_CTLN register that
> + * is used to update interrupt throttling interval for specified ITR index
> + * and optionally enforces a software interrupt. If the @itr_idx is equal
> + * to I40E_ITR_NONE then no interval change is applied and only @force_swint
> + * parameter is taken into account. If the interval change and enforced
> + * software interrupt are not requested then the built value just enables
> + * appropriate vector interrupt.
> + **/
> +static u32 i40e_buildreg_itr(enum i40e_dyn_idx itr_idx, u16 interval,
> +			     bool force_swint)
>   {
>   	u32 val;
>